Post: Use build.os instead of build.image
#233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
reviewed
Aug 3, 2023
Comment on lines
+22
to
+24
| * **Monday, August 28, 2023**: Do the first brownout (temporarily enforce this deprecation) for 12 hours: 00:01 PST to 11:59 PST (noon) | ||
| * **Monday, September 18, 2023**: Do a second brownout (temporarily enforce this deprecation) for 24 hours: 00:01 PST to 23:59 PST (midnight) | ||
| * **Monday, October 2, 2023**: Do a third and final brownout (temporarily enforce this deprecation) for 48 hours: 00:01 PST to October 3, 2023 23:59 PST (midnight) |
There was a problem hiding this comment.
Is it possible to sync up any of these brownouts with our existing brownouts for the config file deprecation? I feel like having a brownout almost every month for the next couple months is a lot. It would be good if we could just codify the brownout (eg. if date(2023, 08, 28) < datetime.now() date(2023, 08, 29) in the code vs. a feature flag)
There was a problem hiding this comment.
Cool. I've done this in 458913eab209217a17791b721e2eb5dfe4b33f1a
Co-authored-by: Eric Holscher <[email protected]>
|
@ericholscher I applied the suggestions and updated the date of the blog post for tomorrow. I think we are ready to merge it now. |
…cs/blog into humitos/build-image-deprecated
ericholscher
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Announcement for readthedocs/readthedocs.org#10589
📚 Rendered version 📚 : https://readthedocs-blog--233.org.readthedocs.build/use-build-os-config/